add two merged boxes to initial lithostatic pressure plugin. #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
approved these changes
Nov 27, 2018
|
This is an example of why we need to get better at letting plugins export this kind of information itself, rather than having to update unrelated places... /run-tests |
|
Our testers seem to have missed this PR, but I tested it locally and it passed all tests. I will take the blame if something goes wrong 😄. |
freddrichards
pushed a commit
to freddrichards/aspect
that referenced
this pull request
May 20, 2019
…s_to_initial_lithostatic_pressure add two merged boxes to initial lithostatic pressure plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two merged boxes should also not convert spherical to cartesian coordinates.